On 18.10.2012 10:45, Simone Caronni wrote: > On 18 October 2012 09:57, Thorsten Leemhuis <fedora@xxxxxxxxxxxxx > <mailto:fedora@xxxxxxxxxxxxx>> wrote: > > --with-egl-platforms=x11,drm%{!?rhel:,wayland} \ > The ",wayland" is not added, as rhel is defined now as 0 when building > with fedpgk. If you build a srpm and try to build it with rpmbuild then > it works, as it's not defined there. I explained it in more detail in > https://bugzilla.redhat.com/show_bug.cgi?id=867375 , which made me > brining up the issue here, as Jesse was unsure how to proceed. > Can't you Just for completeness: Mesa isn't my package. I just build a modified version locally when I ran into trouble that lead to the bug I mentioned. > check that rhel is not defined and different than 0? That's obviously possible. > The packaging guidelines say that a "0" should be used when checking for > conditions: But sometimes people do things wrong :-/ If we define rhel as 0 in redhat-rpm-config then people will notice this case immediately themselves. > With the old one I had to check like this (first line) for building; > which is not correct anyway as the behaviour was different as well > between fedpkg and rpmbuild/mock: [...] And that should not be the case imho. But if we define rhel as 0 in redhat-rpm-config instead (or in addition?) of fedpgk, then your case should remain fixed as well -- or am I missing something? Cu knurd -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
