Re: Package review: SC - Script Collection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Simon Erat wrote:
> What has been prepared so far:
> * http://sf.net/p/seasc (source code, in sub projects)
> * https://bugzilla.redhat.com/show_bug.cgi?id=795696  (review request)
> * http://sea.hostingsociety.com/rpm.sc.template.spec
> * http://sea.hostingsociety.com/changelog
> * http://sea.hostingsociety.com/sc-0.2.0.tar.gz (its a bash script,
> nothing to compile)
> * http://sea.hostingsociety.com/sc-0.2.0-2.fc16.noarch.rpm

First observations:
* Name is too short. A package with such a long history as "ed" can get away 
with a 2-letter name, but yours not really. It's just asking for conflicts…
* The specfile name is not valid (should be %{name}.spec, not
rpm.%{name}.template.spec).

        Kevin Kofler

-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux