On 12/12/2011 11:22 PM, Toshio Kuratomi wrote: > On Mon, Dec 12, 2011 at 10:47:53PM +0200, Ville Skyttä wrote: >> On 12/12/2011 10:29 PM, Stephen Gallagher wrote: >> >>> Patches should never be in the lookaside cache, because >>> it is very difficult to view them. >> >> IMO if that'd be a consideration, the lookaside cache shouldn't really >> exist at all, everything should be in git instead. >> > To some extent I agree with both sgallagh's sentiment and the logical > conclusion you're drawing. However, I think the lookaside cache is > a necessary optimization/compromise to the ideal of putting everything into > version control, though. Current technology would make it prohibitive in > terms of packager time (and for some packages, space on developer's > machines) to put tarballs into git as the cloned repository would then > contain every single new tarball the package ever had. > > So I think for me, lookaside isn't there to separate data from upstream from > data generated by Fedora -- it's there to supplement the SCM when a file is > not suitable for direct inclusion into the SCM. For the same optimization/compromise reasons for me it's a place to put all upstream data, as well as the rare other things for which it makes little sense to store them in the SCM. Upstream data changes between releases, I don't see a reason to carry it in the SCM to the end of time. Actually the only reason why I think Fedora originated patches are better off in git rather than lookaside cache is the gitweb visibility mentioned by sgallagh -- that's our stuff we want others to see and pick up easily whereas from external visibility POV others' stuff is better off just as references to their canonical sources. On the other hand Fedora originated sources that can be sanely stored in git is better off there because in addition to the external visibility point for patches, there's clearly additional value from diffability between revisions to those sources (diffing patches with a SCM is rarely useful (interdiff is another story)). Anyway, I don't care that much if it takes a --force or something like that argument to upload some files to the lookaside cache as long as it can be done. What I do object to is the suggestion to *prevent* doing that for some files altogether. -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
