On 06/23/2011 09:55 AM, Adam Williamson wrote: > On Thu, 2011-06-23 at 20:22 +0400, Pavel Alexeev (aka Pahan-Hubbitus) > wrote: >> To fix [1] and [2] dependency rebuild required. >> Scratch build successful [3], if someone can help on it, I'm ready >> commit and push changes in git. >> Rebuild for rawhide and f15 required. >> >> [1] https://bugzilla.redhat.com/show_bug.cgi?id=710837 >> [2] https://bugzilla.redhat.com/show_bug.cgi?id=712304 >> [3] http://koji.fedoraproject.org/koji/taskinfo?taskID=3155367 >> -- > Also, there's a differing -6 build already in Koji by caillon - > http://koji.fedoraproject.org/koji/buildinfo?buildID=249928 - so you > might want to reconcile your changes with his as -7... I really don't think the changes warrant rebuilding dependent packages anyway, else we would have done that when Colin and I made pretty much the exact same patches yesterday. Btw, simply adding prmjtime.h is insufficient. There are a _bunch_ of header files that were missing from the old package, including about 10 headers and the upstream .pc file. This previously caused gjs to fail to build, which was needed for the Firefox 5 update. Colin and I spent some time debugging this and pushed a fix into F15 yesterday. Coincidentally, it completely fixes 712304 in the most correct way: The old js specfile painstakingly copied individual files one by one into the buildroot. We patched it to run make install DESTDIR=%{buildroot}. Which means all the files that are supposed to be installed get installed. This also puts the headers where they should be, in %{includedir}/js instead of having all of the headers direct children of %{includedir}! The pc files reflect reality, so it should be transparent to consumers as long as they use pkg-config, which they ought to be doing. We also mostly fixed 710837, though we didn't go quite as far as Jasper's patch. Anyway, I'd say you should revert the fix you added for 712304. It's both redundant and incorrect. PS - I probably should have sent you a note about the fixes we did, but it was at the end of a very long day and gjs still didn't build until this morning, and then it just slipped my mind. My bad. -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
