On Tue, 2010-10-12 at 16:54 -0400, Bill Nottingham wrote: > James Laska (jlaska@xxxxxxxxxx) said: > > > 1) When you added this to F14/F15/EL6, you added a typo; this > > > broke the F-14 branched compose and the EPEL updates push. > > > *Please* verify your changes before pushing. > > > > How did the compose break? > > The comps file in git failed to parse, such that the with-translations > comps file could not be made. > > > Is this something that the autoqa > > rats_sanity test [sh|c]ould have caught? > > No, this is well before the tree gets to that state. It would need to > be implemented as a check on git push. We attempt to validate comps in this test using the comps.rng in git (see results logs posted earlier). I'm not tremendously familiar with that part of the test, but I believe it should catch that? https://fedoraproject.org/wiki/QA:Comps_Validity_Test_Case Thanks, James
Attachment:
signature.asc
Description: This is a digitally signed message part
-- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel