lör 2010-05-08 klockan 00:56 +0200 skrev Guido Grazioli:
> Someone would disagree with me; however i think any decision is taken on
> that topic would be turned in a MUST (depend or not depend) for the sake
> of coherency.
I can only think of rather far-fetched situations where such a
dependency would be needed, so I guess I agree...
> This code snippet is telling me that specifying ">= specific_version"
> in BuildRequires: java-devel is optional, while it is mandatory in
> Requires: java
>
> I have no objections to that, but the ant and maven templates below
> must be updated consistently with that.
Good call, fixed.
> 2- JavaDoc installation
>
> "The name of the subdirectory SHOULD be either %{name}
> or %{name}-%{version} with a symlink %{name} pointing to it."
>
> I would turn that in a "MUST be either " one or the other: different directory
> naming should be a rare exception and SHOULD doesnt seem strong enough.
Hmm, I was too lazy to look for current counterexamples which might
provide guidance. Anyone have any? I changed it anyway.
> You could drop the dependency on the main package for the manual too.
Fixed.
> I also would write a more general %add_to_maven_depmap macro call, from:
> %add_to_maven_depmap org.apache.maven %{name} %{version} JPP %{name}
> to:
> %add_to_maven_depmap [groupId] [artifactId] %{version}
> JPP[/optional_subDir] [jarName]
Ok, added with a comment.
> Finally, in the %files section:
> %{_datadir}/maven2/poms/*
> or
> %{mavenpomdir}/*
Ok.
> Hope that helps
Awesome!
/Alexander
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
