Re: rpms/remmina/F-13 import.log,1.1,1.2 remmina.spec,1.4,1.5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, den 16.03.2010, 17:36 +0000 schrieb Damien Durand:
> Author: splinux
> 
> Update of /cvs/pkgs/rpms/remmina/F-13
> In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv21694/F-13
> 
> Modified Files:
> 	import.log remmina.spec 
> Log Message:

Damian,
please give a log message and please DO NOT use cvs-import.sh for
package updates, just commit the changes. With cvs-import you have no
option to change the changes.

> -Requires:       rdesktop, xorg-x11-server-Xephyr
> +Requires:  rdesktop, xorg-x11-server-Xephyr
>  
> -Provides:       grdc = %{version}
> -Obsoletes:      grdc < 0.6.1
> +Provides: grdc = %{version}
> +Obsoletes: grdc < 0.6.1

Although this minor, you broke the formatting and made the spec harder
to read.

>  %description
> -Remmina is a remote desktop client written in GTK+, aiming to be useful for 
> -system administrators and travelers, who need to work with lots of remote 
> -computers in front of either large monitors or tiny netbooks.
> +Remmina is a remote desktop client written in GTK+, aiming to be useful 
> +for system administrators and travellers, who need to work with lots
> +of remote computers in front of either large monitors or tiny netbooks.
>  
> -Remmina supports multiple network protocols in an integrated and consistent
> -user interface. Currently RDP, VNC, XDMCP and SSH are supported.
> +Remmina supports multiple network protocols in an integrated and consistant
> + user interface. Currently RDP, VNC, XDMCP and SSH are supported.

You brought all the typos back that I fixed yesterday! :( Please use
rpmlint to check the spelling.

>  %changelog
> +* Tue Mar 16 2010 Damien Durand <splinux@xxxxxxxxxxxxxxxxx> - 0.7.4-3
> +- Fix changelog
> +
>  * Tue Mar 16 2010 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> - 0.7.4-2
>  - Add patch to fix DSO issue
>  
> @@ -87,7 +90,7 @@ gtk-update-icon-cache %{_datadir}/icons/
>  - Upstream release
>  - Add rdesktop, xorg-x11-server-Xephyr in Requires
>  - Add grdc in Provides/Obsoletes
> -- Add --enable-vnc=dl in %%configure
> +- Add enable-vnc=dl in configure

As you see the changelog was already fixed. There was no need fix
anything, I already fixed everything yesterday but you overwrote my
changes again.

Your updates are completely useless. Please DO NOT push them on any
branch.

Regards,
Christoph

-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux