On Tue, Jan 05, 2010 at 06:34:12PM +0200, Panu Matilainen wrote: > > For the impatient: > > Starting with today's rawhide, the these kind of constructs in specs > no longer "work": > %{?!foo: %define foo bar} > For the generally desired effect, the above simply becomes: > %{?!foo: %global foo bar} > > This is already recommended by the Fedora guidelines, but packages which > haven't been updated to follow the guideline might need revising: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define What exactly do you mean 'no longer work' ? Can we expect to get a formal RPM build error for this bogus construct, or will it silently build and do the wrong thing ? From your long description, it sounds like the latter, which means maintainers should audit their spec files to identify these bogus macros Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- fedora-devel-list mailing list fedora-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-devel-list