On Mon, 2009-09-14 at 09:59 +0200, Michael Schwendt wrote: > On Sun, 13 Sep 2009 19:32:23 +0200, Stefan wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=522933 > > A couple of relevant guideline sections that comment on issues > found quickly in the three spec files: > > https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > https://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries > > > %post > > /sbin/ldconfig > > ... > > > %postun > > /sbin/ldconfig > > ... > > With shell scriptlets, there is no automatic dependency on tools executed > within the script body. You only get an automatic dep on /bin/sh. Hence > more accurate would be to add > > Requires(post): /sbin/ldconfig > Requires(postun): /sbin/ldconfig > > Arguably, that one is part of glibc and should be available. It's just > easy to forget such dependencies for other tools executed in RPM scriptlets. > For example, /usr/bin/xmlcatalog in your %post/postun, even if the > dependency on libxml2 is automatic via the libxml2 library SONAME > (and the tool is included in that package currently). This is quite right and one reason not to publish this RPM ;-) The RPM was only intended as a quick way for me to organize such installations over several computers which are only run by myself. Especially the ldconfig stuff is listed here as a MUST: https://fedoraproject.org/wiki/Packaging/ReviewGuidelines > > %doc %{_mandir}/man1/pbbcmd.1.gz > > %doc %{_mandir}/man1/pbbuttonsd.1.gz > > %doc %{_mandir}/man5/pbbuttonsd.cnf.5.gz > > %doc is automatic for files below %_mandir. > Using "*" instead of ".gz" is more convenient as the compression > technique applied by rpmbuild may change. I would say so too. -- fedora-devel-list mailing list fedora-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-devel-list
