On Thu, 2004-04-08 at 21:37, Toshio wrote:
> On Thu, 2004-04-08 at 14:17, Michael Schwendt wrote:
> > Actually there's a difference between adding a macro like %{disttag}
> > which would be undefined by default and could be set like
> >
> > rpmbuild --rebuild --define "disttag .rh80" foo.src.rpm
> >
> > and hard-coding a disttag in the "Release:" field. ;o)
>
> Roger that. I'll ammend it to say:
>
> Note: If you are building packages for fedora.us, you should not
> hardcode a disttag onto the Release field of the spec file.
Well, IIRC hardcoding is not really a problem, it can be
semi-automatically nuked by the buildsys if the builder person remembers
to include one magic command line option. But (also IIRC) I've seen
macro definition weirdness like in Michael's example case which has
actually resulted in having to manually edit spec files. My .02€:
Note: If you are building packages for fedora.us, do not bother to
include a "disttag" of any kind in the Release field of the spec file.
The build system will do this automatically anyway, so a pre-existing
one will not help at all; it may actually cause problems under some
circumstances.
