gtk-update-icon-cache scriptlet output?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Currently,
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
recommends including scriptlet:
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
but *not* adding any Requires: for this.

A consequence is that when/if gtk-update-icon-cache is not available, the
existing scriptlet generates error output.

2 fixes come to mind:
1. ignore all output: (line wrapped)
%{_bindir}/gtk-update-icon-cache %{_datadir}/icons/hicolor \   
    >& /dev/null || :

2. wrap, allow for real errors to display:
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor ||:
fi

Any opinions on which approach (1 or 2 or other) is a preferred solution
here?  

Myself, I'd lean toward 1 (it's shorter), unless there's value in seeing
possible error output from gtk-update-icon-cache.

-- Rex

p.s.  Looking closer, it appears option 2 was in place at one time, but was
removed via
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=diff&rev2=2&rev1=1
with comment:
Remove extraneous if [ -x PROGRAM ] (Not needed if the scriptlet also
uses ||:)

-- 
Fedora-desktop-list mailing list
Fedora-desktop-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-desktop-list

[Index of Archives]     [Fedora Users]     [Fedora KDE]     [Fedora Announce]     [Fedora Docs]     [Fedora Config]     [PAM]     [Red Hat Development]     [Red Hat 9]     [Gimp]     [Yosemite News]

  Powered by Linux