On Fri, Sep 09, 2005 at 02:16:49PM -0400, Theodore Ts'o wrote: > On Fri, Sep 09, 2005 at 05:43:42PM +0900, Akinobu Mita wrote: > > remove duplicated debug print > > > - jbd_debug(3, "JBD: commit phase 2\n"); > > - > > If you're going to do this, please renumber the rest of the "commit > phase n" messages. Or the debugging messages will look very funny. The second duplicated "commit phase 2" only does: J_ASSERT (commit_transaction->t_sync_datalist == NULL); So I thought it might be accidentaly inserted. diff -U 9 : --- ./fs/jbd/commit.c.orig 2005-09-10 22:09:05.000000000 +0900 +++ ./fs/jbd/commit.c 2005-09-10 22:09:25.000000000 +0900 @@ -419,20 +419,18 @@ write_out_data: cond_resched_lock(&journal->j_list_lock); } spin_unlock(&journal->j_list_lock); if (err) __journal_abort_hard(journal); journal_write_revoke_records(journal, commit_transaction); - jbd_debug(3, "JBD: commit phase 2\n"); - /* * If we found any dirty or locked buffers, then we should have * looped back up to the write_out_data label. If there weren't * any then journal_clean_data_list should have wiped the list * clean by now, so check that it is in fact empty. */ J_ASSERT (commit_transaction->t_sync_datalist == NULL); jbd_debug (3, "JBD: commit phase 3\n"); _______________________________________________ Ext3-users@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/ext3-users
