On Mon, Sep 23, 2002 at 09:43:49PM +0200, Marc-Christian Petersen wrote: > On Monday 23 September 2002 01:33, Theodore Ts'o wrote: > > Hi Theodore, > > I've just tested to compile the kernel w/o ext3 htree support and it fails > like this: > > BTW: Patch used: > http://thunk.org/tytso/linux/ext3-dxdir/patch-2.4.19-ext3-dxdir > > > error: > ... > /linux-2.4.19/arch/i386/lib/lib.a > /linux-2.4.19/lib/lib.a > /linux-2.4.19/arch/i386/lib/lib.a --end-group -o vmlinux > fs/fs.o: In function `ext3_dx_find_entry': > fs/fs.o(.text+0x2e7d2): undefined reference to `dx_probe' > fs/fs.o(.text+0x2e817): undefined reference to `dx_get_block' > fs/fs.o(.text+0x2e8ca): undefined reference to `dx_release' > fs/fs.o(.text+0x2e8d5): undefined reference to `ext3_next_entry' > fs/fs.o(.text+0x2e910): undefined reference to `ext3_htree_next_block' > fs/fs.o(.text+0x2e937): undefined reference to `dx_release' > fs/fs.o: In function `make_indexed_dir': > fs/fs.o(.text+0x2eea3): undefined reference to `dx_set_block' > fs/fs.o(.text+0x2eeae): undefined reference to `dx_set_count' > fs/fs.o(.text+0x2eeb6): undefined reference to `dx_root_limit' > fs/fs.o(.text+0x2eec0): undefined reference to `dx_set_limit' > fs/fs.o(.text+0x2ef25): undefined reference to `do_split' > fs/fs.o(.text+0x2ef33): undefined reference to `dx_release' > make[1]: *** [kallsyms] Error 1 > > any clue? I think the patch is missing some ifdef's? Yeah, the patch only compiles if CONFIG_EXT3_INDEX is defined. I should have a patch out shortly which just simply removes the need to have the #define at all. (The code is quite safe at this point, and it won't do anything if you don't have a filesystem that has the dir_index feature enabled.) - Ted _______________________________________________ Ext3-users@redhat.com https://listman.redhat.com/mailman/listinfo/ext3-users
