On 10/7/24 10:27 AM, Eric Sandeen wrote: > This is lightly tested with the kernel tests present in ecryptfs-utils, > but it could certainly use a bit more testing and review, particularly > with invalid mount option sets. > > This one is a little unique compared to other filesystems in that I > allocate both an fs context and the *sbi in .init_fs_context; the *sbi > is long-lived, and the context is only present during the initial mount. > > Allocating sbi with the filesystem context means we can set options > into it directly, rather than needing to do it after parsing. And it's > particularly simple to do it this way given that there is no remount. > > I could squash these two patches into one if you prefer, but > I thought maybe breaking out the first change made review a little > easier. > > Thanks, > -Eric > Ping on this, I guess. In theory ecryptfs is slated to be deprecated and removed, per https://lore.kernel.org/ecryptfs/ZCuSLNnFQEdOHW0c@sequoia/ but I'm not sure that patch ever got sent. I think this conversion is simple enough, and given that ecrypytfs is still in the tree, it'll stand in the way of removing the old infrastructure whenever the last filesystem finally gets converted, but to be fair we have a little ways to go there. If it's really going to be removed soon (ala reiserfs) then I suppose these patches can be ignored. Thanks, -Eric
