On Sat, Mar 20, 2021 at 09:51:05PM +0000, Al Viro wrote: > calls in ->unlink(), ->rmdir() and ->rename() make sense - we want > to prevent the underlying dentries going negative there. In > ->symlink() and ->link() they are absolutely pointless. [snip] FWIW, that patch series can also be found in git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.ecryptfs; Shortlog: Al Viro (4): ecryptfs: get rid of pointless dget/dput in ->symlink() and ->link() ecryptfs: saner API for lock_parent() ecryptfs: get rid of unused accessors ecryptfs: ecryptfs_dentry_info->crypt_stat is never used Diffstat: fs/ecryptfs/ecryptfs_kernel.h | 17 +---- fs/ecryptfs/inode.c | 163 +++++++++++++++++++----------------------- 2 files changed, 75 insertions(+), 105 deletions(-)