On 2020-12-24 21:22:33, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx> This looks good to me. I've pushed the patch to the eCryptfs next branch: https://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git/log/?h=next Thanks for the cleanup! Tyler > --- > fs/ecryptfs/crypto.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c > index 0681540c48d9..be906b9bbb11 100644 > --- a/fs/ecryptfs/crypto.c > +++ b/fs/ecryptfs/crypto.c > @@ -1590,11 +1590,10 @@ ecryptfs_process_key_cipher(struct crypto_skcipher **key_tfm, > > struct kmem_cache *ecryptfs_key_tfm_cache; > static struct list_head key_tfm_list; > -struct mutex key_tfm_list_mutex; > +DEFINE_MUTEX(key_tfm_list_mutex); > > int __init ecryptfs_init_crypto(void) > { > - mutex_init(&key_tfm_list_mutex); > INIT_LIST_HEAD(&key_tfm_list); > return 0; > } > -- > 2.22.0 >
