Re: [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Eric,

> This series introduces a helper function crypto_shash_tfm_digest() which
> replaces the following common pattern:
> 	{
> 		SHASH_DESC_ON_STACK(desc, tfm);
> 		int err;
> 		desc->tfm = tfm;
> 		err = crypto_shash_digest(desc, data, len, out);
> 		shash_desc_zero(desc);
> 	}
> with:
> 	err = crypto_shash_tfm_digest(tfm, data, len, out);
> Patch 1 introduces this helper function, and patches 2-20 convert all
> relevant users to use it.
> IMO, it would be easiest to take all these patches through the crypto
> tree.  But taking just the "crypto:" ones and then me trying to get the
> rest merged later via subsystem trees is also an option.

I am fine if you take the net/bluetooth/smp.c change through the crypto tree.

Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>



[Index of Archives]     [Linux Crypto]     [Device Mapper Crypto]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux