[PATCH v4 00/20] Xattr inode operation removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is version 4 of the xattr inode operation removal patch series. The
patches are available in git form at:

  https://git.kernel.org/cgit/linux/kernel/git/agruen/linux.git/log/?h=work.xattr

Previous posting: http://www.spinics.net/lists/ecryptfs/msg00791.html


The purpose of this series is to remove unnecessary differences between the
xattr implementations on different filesystems and to simplify things.  With
the exception of redirectors like fuse, overlayfs, and ecryptfs, all
filesystems perform some de-multiplexing based on the xattr name, so it makes
sense to make that the default; filesystems that don't do any de-multiplexing
can easily use a catch-all xattr handler.

The patch series is structured as follows:

 * The first four patches fix a few things and convert overlayfs to use xattr
   handlers; they have been posted to Miklos and linux-unionfs@xxxxxxxxxxxxxxx
   already because they are partially relevant for the 4.8 kernel.

 * The following patches convert the remaining filesystems over to use xattr
   handlers.

 * Next, a new IOP_XATTR inode operations flag is introduced: the flag is set
   when an inode supports xattrs.  On most filesystems, the IOP_XATTR flag is
   automatically initialized correctly when the inode is allocated based on
   whether or not the s_xattr field in the inode's superblock is defined.
   Filesystems that support xattrs on some but not all inodes can clear the
   IOP_XATTR flag appropriately.

 * The IOP_XATTR flag is then used to get rid of the two remaining places where
   xattr inode operations other than the generic ones are used: bad inodes and
   libfs empty directories.

 * After that, we get rid of the remaining direct accesses to xattr inode
   operations.

 * Finally, we stop calling the xattr inode operations and remove them.

Note that these patches only remove the getxattr, setxattr, and removexattr
inode operations. The listxattr inode operation does not do any attribute name
de-multiplexing, and remains unchanged except for checking the new IOP_XATTR
flag as well now.


Thanks,
Andreas


Andreas Gruenbacher (20):
ovl: Fix OVL_XATTR_PREFIX
ovl: Get rid of ovl_xattr_noacl_handlers array
ovl: Switch to generic_removexattr
ovl: Switch to generic_getxattr
xattr: Remove unnecessary NULL attribute name check
jffs2: Remove jffs2_{get,set,remove}xattr macros
hfs: Switch to generic xattr handlers
kernfs: Switch to generic xattr handlers
sockfs: getxattr: Fail with -EOPNOTSUPP for invalid attribute names
sockfs: Get rid of getxattr iop
ecryptfs: Switch to generic xattr handlers
fuse: Switch to generic xattr handlers
vfs: Move xattr_resolve_name to the front of fs/xattr.c
vfs: Add IOP_XATTR inode operations flag
vfs: Use IOP_XATTR flag for bad-inode handling
libfs: Use IOP_XATTR flag for empty directory handling
xattr: Add __vfs_{get,set,remove}xattr helpers
vfs: Check for the IOP_XATTR flag in listxattr
xattr: Stop calling {get,set,remove}xattr inode operations
vfs: Remove {get,set,remove}xattr inode operations

Documentation/filesystems/Locking     |  24 +++-
Documentation/filesystems/vfs.txt     |  45 ++++--
fs/9p/vfs_inode_dotl.c                |   9 --
fs/bad_inode.c                        |  21 +--
fs/btrfs/inode.c                      |  12 --
fs/cachefiles/bind.c                  |   4 +-
fs/cachefiles/namei.c                 |   4 +-
fs/ceph/dir.c                         |   3 -
fs/ceph/inode.c                       |   6 -
fs/cifs/cifsfs.c                      |   9 --
fs/ecryptfs/ecryptfs_kernel.h         |   2 +
fs/ecryptfs/inode.c                   |  67 ++++++---
fs/ecryptfs/main.c                    |   1 +
fs/ecryptfs/mmap.c                    |  13 +-
fs/ext2/file.c                        |   3 -
fs/ext2/namei.c                       |   6 -
fs/ext2/symlink.c                     |   6 -
fs/ext4/file.c                        |   3 -
fs/ext4/namei.c                       |   6 -
fs/ext4/symlink.c                     |   9 --
fs/f2fs/file.c                        |   3 -
fs/f2fs/namei.c                       |  12 --
fs/fuse/dir.c                         |  49 +++++--
fs/fuse/fuse_i.h                      |   2 +
fs/fuse/inode.c                       |   1 +
fs/gfs2/inode.c                       |   9 --
fs/hfs/attr.c                         |  83 +++++++----
fs/hfs/hfs_fs.h                       |   6 +-
fs/hfs/inode.c                        |   5 +-
fs/hfs/super.c                        |   1 +
fs/hfsplus/dir.c                      |   3 -
fs/hfsplus/inode.c                    |   3 -
fs/inode.c                            |   2 +
fs/jffs2/dir.c                        |   3 -
fs/jffs2/file.c                       |   3 -
fs/jffs2/symlink.c                    |   3 -
fs/jffs2/xattr.h                      |   6 -
fs/jfs/file.c                         |   3 -
fs/jfs/namei.c                        |   3 -
fs/jfs/symlink.c                      |   6 -
fs/kernfs/dir.c                       |   3 -
fs/kernfs/inode.c                     | 155 +++++++++++----------
fs/kernfs/kernfs-internal.h           |   7 +-
fs/kernfs/mount.c                     |   1 +
fs/kernfs/symlink.c                   |   3 -
fs/libfs.c                            |  29 +---
fs/nfs/nfs3proc.c                     |   6 -
fs/nfs/nfs4proc.c                     |   6 -
fs/ocfs2/file.c                       |   3 -
fs/ocfs2/namei.c                      |   3 -
fs/ocfs2/symlink.c                    |   3 -
fs/orangefs/inode.c                   |   3 -
fs/orangefs/namei.c                   |   3 -
fs/orangefs/symlink.c                 |   1 -
fs/orangefs/xattr.c                   |   3 +
fs/overlayfs/copy_up.c                |   4 +-
fs/overlayfs/dir.c                    |   3 -
fs/overlayfs/inode.c                  |  88 +++---------
fs/overlayfs/overlayfs.h              |  12 +-
fs/overlayfs/super.c                  |  69 ++++++----
fs/reiserfs/file.c                    |   3 -
fs/reiserfs/namei.c                   |   9 --
fs/squashfs/inode.c                   |   1 -
fs/squashfs/namei.c                   |   1 -
fs/squashfs/symlink.c                 |   1 -
fs/squashfs/xattr.c                   |  19 ++-
fs/squashfs/xattr.h                   |   1 -
fs/ubifs/dir.c                        |   3 -
fs/ubifs/file.c                       |   6 -
fs/xattr.c                            | 250 ++++++++++++++++------------------
fs/xfs/xfs_iops.c                     |  15 --
include/linux/fs.h                    |  23 ++--
include/linux/xattr.h                 |   7 +-
mm/shmem.c                            |  15 --
net/socket.c                          |  70 +++++-----
security/commoncap.c                  |  25 ++--
security/integrity/evm/evm_crypto.c   |   7 +-
security/integrity/evm/evm_main.c     |   4 +-
security/integrity/ima/ima_appraise.c |  21 ++-
security/selinux/hooks.c              |  19 +--
security/smack/smack_lsm.c            |  12 +-
81 files changed, 602 insertions(+), 774 deletions(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Crypto]     [Device Mapper Crypto]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux