Re: [PATCH v3 00/17] Xattr inode operation removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/30/16, Andreas Gruenbacher <agruenba@xxxxxxxxxx> wrote:
> On Mon, May 30, 2016 at 11:54 AM, Sedat Dilek <sedat.dilek@xxxxxxxxx>
> wrote:
>> On 5/30/16, Andreas Gruenbacher <agruenba@xxxxxxxxxx> wrote:
>>> This is version 3 of the xattr inode operation removal patch series. The
>>> patches are available in git form at:
>>>
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/agruen/linux.git/log/?h=work.xattr
> [...]
>>>
>> Hi,
>>
>> I pulled in agruen/linux.git#work.xattr on top of Linux v4.7-rc1 and
>> noticed...
>>
>>  92 files changed, 563 insertions(+), 703 deletions(-)
>>
>> So this is on top of Linux v4.7-rc1+?
>
> Well, I've actually rebased the patches on top of commit b02b1fbd
> which is the current mainline and one merge after v4.7-rc1, but the
> few scsi commits in between -rc1 and b02b1fbd are completely
> unrelated. You can easily see that in git.
>

I have seen the scsi changes when I ran my script which generates a
patchset where latest "git-tag in Linus tree" is the base, here
v4.7-rc1.

>> I am here on Ubuntu/precise AMD64 realized as a WUBI-installation.
>> So I use fuse, loop-device and ext4-fs.
>>
>> Not sure, how to test your patchset.
>> Can you give some instructions on a testcase/usecase?
>
> The patches potentially affect xattrs and anthing that's xattr based,
> like POSIX ACLs, SELinux, and Smack. There are some POSX ACL tests in
> xfstests. The basic xattr functionality can of course be checked with
> getfattr / setfattr. Other than that, I can probably only refer you to
> the code itself.
>

Here I have LTP v20160126 installed.

# cat /opt/ltp/Version
20160126

I ran acl_test01 (which I hacked a bit)...

# LC_ALL=C ./runltp -s acl_test01 | tee acl_test01.log

# cat results/LTP_RUN_ON-2016_05_30-14h_52m_29s.log
Test Start Time: Mon May 30 14:52:30 2016
-----------------------------------------
Testcase                       Result     Exit Value
--------                       ------     ----------
acl_test01                     PASS       0

-----------------------------------------------
Total Tests: 1
Total Skipped Tests: 0
Total Failures: 0
Kernel Version: 4.7.0-rc1-2-iniza-small
Machine Architecture: x86_64
Hostname: fambox

...and it looks good.

>> Booting into a kernel with your patchset looks fine to me - on the 1st
>> sight.
>
> Okay, thanks.
>

Cannot say if this helps you.

- Sedat -

P.S.: Hacking acl_test01

# diff -uprN ./testcases/bin/acl_test01.orig ./testcases/bin/acl_test01
--- ./testcases/bin/acl_test01.orig     2016-03-27 21:45:00.768007420 +0200
+++ ./testcases/bin/acl_test01  2016-05-30 14:41:50.195986299 +0200
@@ -41,8 +41,6 @@ export TCID=acltest01
 export TST_TOTAL=5
 export TST_COUNT=1

-. test.sh
-
 TMP=${TMP:=/tmp}

 TEST_USER1="acltest1"
@@ -54,6 +52,8 @@ FILE_ACL="$TMP/tacl/mount-ext3/test_file
 FILE_ACL_LINK="$TMP/tacl/mount-ext3/test_file_link"
 TCbin=`pwd`

+. $TCbin/test.sh
+
 COMMAND=$(command -v "getenforce" "setenforce" |wc -l)
 if [ $COMMAND -eq 2 ]; then
        SELINUX=$(getenforce)

- EOT -

Attachment: acl_test01.log
Description: Binary data

Attachment: LTP_RUN_ON-2016_05_30-14h_52m_29s.log
Description: Binary data


[Index of Archives]     [Linux Crypto]     [Device Mapper Crypto]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux