- for nixos/old kernels, the current pahole version produces reproducible output if SOURCE_DATE_EPOCH is set (because someone patched it to default to -j1 in this case in our tree), and now the reproducible build option exists I'd like to upstream something more appropriate that'll "just work" without worrying about old kernel trees and adding new explicit pahole arguments there. So adding a new switch to set a flag from env probably won't help me much, but a new env var like PAHOLE_BTF_FEATURES (PAHOLE_FLAGS is used/overwritten by Kbuild...) that would just call into the --btf-feature parsing code, e.g. exporting PAHOLE_BTF_FEATURES=+reproducible_build would toggle the option) would probably work for me. (Have to be careful that this is not the same as --reproducible-build, so perhaps something else might be better... but regardless it'll probably work out for linux kernel builds) It's less convenient than having SOURCE_DATE_EPOCH just "make it work", but at least there'll be a single place to edit that'll work on all older kernels for a given distro. (and the "just work" side of things might come for newer kernels at some point for distros that care less...) What do you think? -- Dominique Martinet | Asmadeus
