On 8/7/21 5:11 AM, Andrii Nakryiko wrote: > On Fri, Aug 6, 2021 at 11:42 AM Arnaldo Carvalho de Melo > <arnaldo.melo@xxxxxxxxx> wrote: >> >> Em Fri, Aug 06, 2021 at 06:12:43PM +0800, Joseph Qi escreveu: >>> Otherwise it will encounter the following error: >>> fatal: unable to access 'https://github.com/libbpf/libbpf/': Encountered end of file >>> fatal: clone of 'https://github.com/libbpf/libbpf' into submodule path '/home/workspace/pahole/lib/bpf' failed >>> >>> Also update README to add step 'make'. >> >> You forgot to add Andrii, the author of the patch you're fixing, to the >> CC list, please do it next time. > > Heh, thanks! Don't worry, I'm subscribed to dwarves@vger, so I saw this anyways. > >> >> - Arnaldo >> >>> Fixes: 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf") >>> Signed-off-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx> >>> --- >>> .gitmodules | 2 +- >>> README | 3 ++- >>> 2 files changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/.gitmodules b/.gitmodules >>> index 6be99dc..8be5eb6 100644 >>> --- a/.gitmodules >>> +++ b/.gitmodules >>> @@ -1,3 +1,3 @@ >>> [submodule "lib/bpf"] >>> path = lib/bpf >>> - url = https://github.com/libbpf/libbpf >>> + url = https://github.com/libbpf/libbpf.git > > This doesn't hurt, but as Arnaldo pointed out, it seems to work just > fine as is. Not sure how you ran into this problem... And why did it > append the final '/' (still don't know if that's the reason)? > I just follow the README and have got the problem. I'll try to figure it why I can't pass in my environment. Thanks, Joseph
