Re: [PATCH 2/2] README: add documentation for -DBUILD_SHARED_LIBS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnaldo,

On 6/2/21 6:48 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jun 02, 2021 at 11:26:24AM +0530, Deepak Kumar Mishra escreveu:
>> added a section in README to give details about use of -DBUILD_SHARED_LIBS
>> cmake option and existing documentation reformatted to accomodate this.
> 
> So are you changing the default to build as static? Please keep the
> existing default and make building statically the opt-in mode, ok?
> 
As per Cmake documentation if -DBUILD_SHARED_LIBS is present and true, 
cmake will cause all libraries to be built shared.
https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html 

If you still suggest, I can override the default behavior to SHARED and 
only when -DBUILD_SHARED_LIBS=OFF is provided, it will make STATIC.

Kindly confirm. 
-Deepak 

> - Arnaldo
>  
>> Signed-off-by: Deepak Kumar Mishra <deepakkumar.mishra@xxxxxxx>
>> ---
>>  README | 13 +++++++++++--
>>  1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/README b/README
>> index 576cd42..40ca984 100644
>> --- a/README
>> +++ b/README
>> @@ -6,8 +6,17 @@ Build instructions:
>>  4. cmake -D__LIB=lib ..
>>  5. make install
>>  
>> -Default is to install to /usr/local, use -DCMAKE_INSTALL_PREFIX=
>> -when invoking cmake to specify another install location.
>> +cmake Options:
>> +  -DBUILD_SHARED_LIBS
>> +    By default STATIC libraries are created and applications are linked to it.
>> +    use -DBUILD_SHARED_LIBS=ON while invoking cmake to create SHARED libraries
>> +    and link applications to it.
>> +
>> +    Ex. cmake -D__LIB=lib -DBUILD_SHARED_LIBS=ON ..
>> +
>> +  -DCMAKE_INSTALL_PREFIX
>> +    Default is to install to /usr/local, use -DCMAKE_INSTALL_PREFIX=
>> +    when invoking cmake to specify another install location.
>>  
>>  Known to work scenarios:
>>  
>> -- 
>> 2.17.1
>>
> 



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux