Re: [PATCH v2] pahole: Add --kabi_prefix flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 19, 2021 at 05:23:31PM -0300, Arnaldo wrote:
> 
> 
> On May 19, 2021 5:07:03 PM GMT-03:00, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> >On Wed, May 19, 2021 at 10:44:44AM +0800, Shuyi Cheng wrote:
> >> To solve problems similar to _RH_KABI_REPLACE. The
> >_RH_KABI_REPLACE(_orig,
> >> _new) macros perserve size alignment and kabi agreement between _orig
> >and
> >> _new.Below is the definition of this macro:
> >> 
> >> # define _RH_KABI_REPLACE(_orig, _new)            \
> >>     union {                        \
> >>         _new;                    \
> >>         struct {                \
> >>             _orig;                \
> >>         } __UNIQUE_ID(rh_kabi_hide);        \
> >>         __RH_KABI_CHECK_SIZE_ALIGN(_orig, _new);    \
> >>     }
> >
> >hi,
> >that macro sounds familiar ;-) I think this should be already
> >solved directly in the header file by this one:
> >
> >https://gitlab.com/cki-project/kernel-ark/-/commit/331be9c5a436057ee852075c102d9d90a9046a30
> >
> 
> But this means newer kernels will not have that issue, so perhaps we should just document this?

I don't think there's released kernel with this issue

> 
> Or would it be worth the effort of having a --ignore_prefix option for the people using all the kernels where this is applicable to and leave the option lingering there just in case?

this is specific to rh kernels and fixed by that patch above,
I wouldn't expect seeing it again

jirka




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux