On Tue, 2021-03-30 at 13:47 +0900, Dominique Martinet wrote: > Hi, > > I see this commit has been reverted just before the 1.20 release in Feb: > --- > Revert "libbpf: allow to use packaged version" > > This reverts commit 82749180b23d3c9c060108bc290ae26507fc324e. > > Getting in the way of releasing 1.20, breaking the build of a dwarves > rpm when a libbpf package is installed in a fedora 33 system: > > In file included from /home/acme/rpmbuild/BUILD/dwarves-1.20/strings.c:7: > /home/acme/rpmbuild/BUILD/dwarves-1.20/pahole_strings.h:9:10: fatal error: bpf/btf.h: No such file or directory > 9 | #include <bpf/btf.h> > | ^~~~~~~~~~~ > > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > --- > > I can understand reverting due to other pressure to get a release out > but most distros (including fedora) frown upon vendoring code so I think > it would be good to have back ultimately. > > Did you or someone else (Luca?) ever take the time to look at it? > > I don't see what would be so different with fedora to make this > unfixable, I'd be happy taking a look if nobody has so far. > Would you take the patch back in if I somehow fix rpmbuild with a libbpf > package installed on fedora33? > > > Thanks, Hi, I did not realise it was reverted (if I was pinged and I missed it: sorry about that) - what was the issue precisely? This has been used on Ubuntu and Debian for a few months now, no problems reported. Happy to have a look too if needed. -- Kind regards, Luca Boccassi
Attachment:
signature.asc
Description: This is a digitally signed message part
