Re: [PATCH PING dwarves] btf: Add --btf_gen_all flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2021-03-23 at 15:22 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Mar 23, 2021 at 03:07:23PM -0300, Arnaldo Carvalho de Melo
> escreveu:
> > Em Tue, Mar 23, 2021 at 02:36:48PM +0100, Ilya Leoshkevich
> > escreveu:
> > > On Fri, 2021-03-12 at 10:39 -0300, Arnaldo Carvalho de Melo
> > > wrote:
> > > > Em Fri, Mar 12, 2021 at 01:08:08AM +0100, Ilya Leoshkevich
> > > > escreveu:
> > > > > By default, pahole makes use only of BTF features introduced
> > > > > with
> > > > > kernel v5.2. Features that are added later need to be turned
> > > > > on with
> > > > > explicit feature flags, such as --btf_gen_floats. According
> > > > > to [1],
> > > > > this will hinder the people who generate BTF for kernels
> > > > > externally
> > > > > (e.g. for old kernels to support BPF CO-RE).
> > > > > 
> > > > > Introduce --btf_gen_all that allows using all BTF features
> > > > > supported
> > > > > by pahole.
> > > > > 
> > > > > [1] 
> > > > > https://lore.kernel.org/dwarves/CAEf4Bzbyugfb2RkBkRuxNGKwSk40Tbq4zAvhQT8W=fVMYWuaxA@xxxxxxxxxxxxxx/
> > > > 
> > > > Applied locally, testing ongoing.
> > > > 
> > > > Also added this:
> > > > 
> > > > Suggested-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> > > > 
> > > > - Arnaldo
> > > 
> > > [...]
> > > 
> > > Hi Arnaldo,
> > > 
> > > I'd like to ping this patch (and
> > > https://lore.kernel.org/dwarves/20210310201550.170599-1-iii@xxxxxxxxxxxxx/
> > > too).
> > 
> > So I finally finished testing, pushing out now.
> 
> Please check what is in
> https://git.kernel.org/pub/scm/devel/pahole/pahole.git/, I'm having
> some
> problems with 2FA on github, will fix soon.
> 
> - Arnaldo

That looks good, thanks!

s390 seems to run fine again with the latest bpf-next / llvm / pahole.
Now I can finally give adding s390 to the libbpf CI another try :-)




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux