On Thu, 2021-01-21 at 17:34 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jan 21, 2021 at 12:02:53PM -0800, Andrii Nakryiko escreveu: > > On Thu, Jan 21, 2021 at 5:29 AM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote: > > > Em Mon, Jan 04, 2021 at 10:17:36PM +0000, Luca Boccassi escreveu: > > > > On Mon, 2021-01-04 at 12:23 -0800, Andrii Nakryiko wrote: > > > > > One quick and easy hack would be to put a symlink lib/include/bpf -> > > > > > lib/bpf/src into pahole repo. And add -Ilib/include to let compiler > > > > > handle <bpf/*.h> properly. > > > > Sure, that works for me if it's acceptable as a solution. Sent v3 that > > > > implements it. Thanks for the suggestion. > > > > > > Andrii, can I have your Reviewed-by or Acked-by for v3? > > > > Well, I still think it's not good and not necessary for pahole. pahole > > doesn't run under root. It's not a networking application open to the > > world either. So I don't buy security arguments in this case at all. > > So no, feel free to push this, but without my ack. > > Ok, fair enough, I applied the patch, the default behaviour is the one > we like, so should be no problem for us :-) Thank you! -- Kind regards, Luca Boccassi
Attachment:
signature.asc
Description: This is a digitally signed message part
