Em Tue, Nov 05, 2019 at 03:03:57PM +0100, Jiri Olsa escreveu:
> hi,
> while adding the RHEL package one of the checks failed
> saying that there's no actual version dependency between
> dwarves nad libdwarves1:
>
> Subpackage dwarves on aarch64 x86_64 ppc64le s390x consumes libraries libdwarves.so.1()(64bit) libdwarves_emit.so.1()(64bit) libdwarves_reorganize.so.1()(64bit) from subpackage libdwarves1 but does not have explicit package version requirement.
> Please add Requires: libdwarves1 = %{version}-%{release} to dwarves in the specfile to avoid the need to test interoperability between the various combinations of old and new subpackages.
>
> It's also not present in fedora and I think that's what we want,
> because it's also present for -devel pacakge.. please consider
> patch below for fedora package.
>
> koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=38777298
>
> [jolsa@krava trash]$ rpm -qp --requires dwarves-1.15-4.fc32.x86_64.rpm | grep libdwarves1
> libdwarves1 = 1.15-4.fc32
That is ok, from another live as a packager, I thought this would be
automagically added, no? For instance, if I install it here in my
fedora30 workstation:
[root@quaco ~]# dnf install dwarves
Fedora Modular 30 - x86_64 3.0 kB/s | 3.0 kB 00:01
Fedora Modular 30 - x86_64 - Updates 38 kB/s | 43 kB 00:01
Fedora 30 - x86_64 - Test Updates 29 kB/s | 29 kB 00:01
Fedora 30 - x86_64 - Updates 5.9 kB/s | 3.1 kB 00:00
Fedora 30 - x86_64 5.4 kB/s | 3.1 kB 00:00
RPM Fusion for Fedora 30 - Free - Updates 12 kB/s | 14 kB 00:01
RPM Fusion for Fedora 30 - Free 19 kB/s | 14 kB 00:00
Dependencies resolved.
===============================================================================================================================================================================================================================================
Package Architecture Version Repository Size
===============================================================================================================================================================================================================================================
Installing:
dwarves x86_64 1.15-2.fc30 updates 84 k
Installing dependencies:
libdwarves1 x86_64 1.15-2.fc30 updates 106 k
Transaction Summary
===============================================================================================================================================================================================================================================
Install 2 Packages
Total download size: 191 k
Installed size: 661 k
Is this ok [y/N]:
It grabs the deps, then:
[root@quaco ~]# rpm -qR dwarves | grep dwarves
libdwarves.so.1()(64bit)
libdwarves_emit.so.1()(64bit)
libdwarves_reorganize.so.1()(64bit)
[root@quaco ~]#
But you mean get this to be completely tying one version of dwarves to
the exact same RPM package version, I see, at this point indeed this is
adviseable...
I'll pick it for the git repo .spec file,
- Arnaldo
> thanks,
> jirka
>
>
> ---
> dwarves.spec | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/dwarves.spec b/dwarves.spec
> index 1f098454c956..9bae5ef8ab96 100644
> --- a/dwarves.spec
> +++ b/dwarves.spec
> @@ -3,7 +3,7 @@
>
> Name: dwarves
> Version: 1.15
> -Release: 3%{?dist}
> +Release: 4%{?dist}
> License: GPLv2
> Summary: Debugging Information Manipulation Tools (pahole & friends)
> URL: http://acmel.wordpress.com
> @@ -13,6 +13,7 @@ BuildRequires: gcc
> BuildRequires: cmake
> BuildRequires: zlib-devel
> BuildRequires: elfutils-devel >= 0.130
> +Requires: %{libname}%{libver} = %{version}-%{release}
>
> %description
> dwarves is a set of tools that use the debugging information inserted in
> @@ -119,6 +120,9 @@ make install DESTDIR=%{buildroot}
> %{_libdir}/%{libname}_reorganize.so
>
> %changelog
> +* Tue Nov 05 2019 Jiri Olsa - 1.15-4
> +- add libdwarves version dependency to dwarves package
> +
> * Wed Jul 24 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.15-3
> - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
>
> --
> 2.21.0
--
- Arnaldo
