[PATCH pahole 0/4] pahole --reorganize fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Andrii Nakryiko <andriin@xxxxxx>

This patchset fixes a bunch of issues with pahole --reorganize. It should
be applied on top of previous patchset with various bitfield fixes.

Patch #1 reverts the meaning of member->bit_hole and member->hole to mean
"hole after member", which allows for easier adaptation of --reorganize.
Patch #2 fixes small bug in class__find_holes() mis-categorizing byte hole
as bit hole in certain circumstances.
Patch #3 eliminates a lot of ad-hoc adjustments of holes in reorganize code
and instead relies on re-calculation of them using class__find_holes().
Patch #4 fixes bug in class__reorganize() causing invalid adjustments of field
offsets when moving bitfields around. It could cause BRAIN FART ALERTS during
reorganization.

Andrii Nakryiko (4):
  dwarves: revert semantics of member bit/byte hole
  dwarves: fix classification of byte/bit hole for aligned bitfield
  reorganize: use class__find_holes() to recalculate holes
  reorganize: shift tail members for non-bitfields only

 dwarves.c            |  15 ++++--
 dwarves.h            |   2 +
 dwarves_fprintf.c    |  72 ++++++++++++++++---------
 dwarves_reorganize.c | 125 +++++++++++++------------------------------
 4 files changed, 97 insertions(+), 117 deletions(-)

-- 
2.17.1




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux