On Mon, Feb 18, 2019 at 11:55 AM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote: > > Em Mon, Feb 18, 2019 at 11:38:41AM -0800, Andrii Nakryiko escreveu: > > On Mon, Feb 18, 2019 at 6:29 AM Arnaldo Carvalho de Melo wrote: > > > Thanks for all the cool work! > > > My pleasure, it was fun! :) > > So, next step, tag a pahole release and announce it, but I wonder about > the libbpf linking, wouldn't be better, for now, to make it link > statically with libbpf? > > I ask this because libbpf isn't yet generally available, so perhaps we > should have some logic to detect if it is available and link against it > or if not, use the module stuff we have now and link it statically, > wdyt? I agree. Now the question is how to do it. The easiest way to do this is to make bpf-static an OBJECT library in cmake, which will make it compile as PIC library. But that feature requires cmake 2.8.8. Would you be ok to bump minimum version of cmake to 2.8.8 (it's 2.4.8 right now). If not, do you now what's the proper way to do this right now with older cmake? > > Hopefully we get the problems noticed via btfdiff before that. > > - Arnaldo
