On Wed, Feb 6, 2019 at 2:06 PM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote: > > Em Wed, Feb 06, 2019 at 01:25:12PM -0800, Andrii Nakryiko escreveu: > > On Wed, Feb 6, 2019 at 1:18 PM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote: > > > So either resubmit this or let me know if I can keep these on and you > > > can continue on top of it, ok? > > > Let me dig into all those warning and try to fix them. There is no > > rush in landing this patchset immediately, I was mostly trying to get > > consensus on whether using libbpf from submodule is ok for now (until > > we have more readily available and more stable libbpf as a shared > > lib). > > Then its just a warning, and one that will get fixed in the libbpf > codebase, no? > > I took a look at 'man bzero' and it is defined in strings.h, is that > being included in the libbpf file that uses it? lemme check in the > kernel sources.... > > [acme@quaco linux]$ grep -wl bzero tools/lib/bpf/*.c > tools/lib/bpf/bpf.c > tools/lib/bpf/btf.c > tools/lib/bpf/libbpf.c > [acme@quaco linux]$ grep -wl bzero tools/lib/bpf/*.c | xargs grep "include.*strings.h" > [acme@quaco linux]$ grep -wl bzero tools/lib/bpf/*.c | xargs grep "include.*string.h" > tools/lib/bpf/btf.c:#include <string.h> > tools/lib/bpf/libbpf.c:#include <string.h> > [acme@quaco linux]$ grep -wl bzero tools/lib/bpf/*.c | xargs grep "include.*strings.h" > [acme@quaco linux]$ > > Its not, so its just a matter of adding it? > > it gets added via /usr/include/string.h if __USE_MISC is defined, so > probably this is done in a not determinist way which ends up showing up > in my case but not in yours Cool, thanks for investigating! That's easy to fix, will fix libbpf and will update submodule reference and re-submit this patchset. > > > > At some point we just switch to linking dynamicly with libbtf, when it > > > becomes more generally available. > > > Yep, I agree. > > - Arnaldo
