Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add i915 perf event for Haswell OA unit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Robert,

[auto build test WARNING on v4.4-rc8]
[cannot apply to drm-intel/for-linux-next v4.5-rc2 v4.5-rc1 next-20160202]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Robert-Bragg/Enable-Gen-7-Observation-Architecture/20160203-053423
config: i386-defconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/i915_perf.c: In function 'gen7_oa_read':
>> drivers/gpu/drm/i915/i915_perf.c:264:2: warning: #warning "WIP: check the correct way to clear OASTATUS1 bits" [-Wcpp]
    #warning "WIP: check the correct way to clear OASTATUS1 bits"
     ^

vim +264 drivers/gpu/drm/i915/i915_perf.c

   248						       DRM_I915_PERF_RECORD_OA_REPORT_LOST);
   249				if (n_records && ret == -EFAULT)
   250					ret = 0;
   251				else if (ret < 0)
   252					return ret;
   253				else if (ret > 0) {
   254					n_records += ret;
   255					oastatus1 &= ~GEN7_OASTATUS1_REPORT_LOST;
   256				}
   257			}
   258	
   259			/* XXX: This register contains the OA tail pointer
   260			 * which may be updated asynchronously while periodic
   261			 * sampling is enabled so it's racy to
   262			 * read-modify-write like we are here (esp after the
   263			 * append/copy_to_user work above.) */
 > 264	#warning "WIP: check the correct way to clear OASTATUS1 bits"
   265			I915_WRITE(GEN7_OASTATUS1, oastatus1);
   266		}
   267	
   268		/* If there is still buffer space */
   269		if (ret) {
   270			ret = gen7_append_oa_reports(stream, read_state, &head, tail);
   271			if (n_records && ret == -EFAULT)
   272				ret = 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux