Re: [PATCH libdrm] tests: util: Fixup util_open() parameter order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5 January 2016 at 14:21, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> util_open() takes a device parameter, followed by a module parameter.
> The existing tests used the drmOpen() function, which uses a different
> ordering of the parameters, and the old ordering was accidentally kept
> during the conversion.
>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
> Evidently I didn't properly test this. Things do work in most cases
> with the current code because of the auto-detection, but there will
> be cases where it fails.
>
Having the module name identical to the device name also helps ;-)
But seriously - nicely spotted. I'll going through the list and I'll
push this out shortly.

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux