Hi Lucas,
Thanks for the review.
On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@xxxxxxxxxx> wrote:
> > drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
>
> Missing documentation for the DT binding.
>
Thanks, will add.
...
> > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
>
> > static const struct display_timing hannstar_hsd070pww1_timing = {
> > .pixelclock = { 64300000, 71100000, 82000000 },
> > .hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> > .compatible = "hannstar,hsd070pww1",
> > .data = &hannstar_hsd070pww1,
> > }, {
> > + .compatible = "sharp,lq101k1ly04",
> > + .data = &sharp_lq101k1ly04,
> > + }, {
>
> Wrong insertion place again.
OK. Will reorder alphabetically also.
Joshua
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
