> > 1. As UP replies also got to slots (even as mentioned in code it > should not happen), we should clean them somewhere. For DOWN requests they > are cleaned on DOWN reply when full reply received. However we will not > receive interrupt when UP reply sent; > > 2. I am not sure if DRM process DOWN requests or UP reply with length > more than 1 SB currently, though it does process DOWN replies. First SB is > sent right away message is submit. Left part intended to be send in > drm_dp_tx_work, which is scheduled from drm_dp_mst_hpd_irq, which should be > called from DP short pulse interrupt. However short pulse will not come for > the part of DOWN request, nor for part of UP reply. As I understand we do > not have issues right now as there is no DOWN request or UP reply longer > than 1 SB; > > 3. not sure if it is needed to use queue for UP replies. As soon as > full UP request received, we should send full reply right away, processing > AUX_DEFER just in case; > > 4. If above points right, sending of MST messages bigger than 1 SB > should be addressed as a separate patch, not in topic patch. > Okay this makes sense to me, Ack for all four patches to go via Alex for this merge window, Alex can you add cc stable to these and send at least these ones and the two latest ones. Thanks, Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
