On 12/28/15 23:51, Joerg Roedel wrote: > On Sat, Dec 26, 2015 at 09:26:32PM +0800, chengang@xxxxxxxxxxxxxxxx wrote: >> >> It is architecture specific mechanism header, not generic header, so >> move it to arch/x86/include/asm. > > There might be future non-x86 hardware which also has an amd iommu, so > the header file should stay where it is for now. > For me, amd-iommu.h is architecture specific, for this kind of headers, if it is used by most of archs, it will be in "include/asm-generic". If it is used by several archs, it will be in "arch/*/include/asm/". So for me, at present, it is only used by x86, so is move to "arch/x86/ include/asm/"; if another archs want it, they can copy one. If quite a few archs (e.g. > 3 archs) need it, move it to "include/asm-generic". Thanks. -- Chen Gang (陈刚) Open, share, and attitude like air, water, and life which God blessed _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
