Re: [PATCH 4/6] drm/rockchip: vop: spilt scale regsters

[Mark yao <mark.yao@xxxxxxxxxxxxxx>]

On 2015年12月17日 11:37, Mark Yao wrote:

@@ -242,6 +247,11 @@ static inline uint16_t scl_cal_scale(int src, int dst, int shift)
 	return ((src * 2 - 3) << (shift - 1)) / (dst - 1);
 }
 
+static inline uint16_t scl_cal_scale2(int src, int dst)
+{
+	return (src - 1) << 12 / (dst - 1);
+}
+

Sorry, There is a mistake here, lose a parenthesis after code formating, it should be:

+static inline uint16_t scl_cal_scale2(int src, int dst)
+{
+	return ((src - 1) << 12) / (dst - 1);
+}
+

Without the parenthesis would cause rk3036 scale abnormal.
I would send v1.1 patch to fix it.

Thanks.

-- 
Ｍark Yao

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel