On Thu, Dec 03, 2015 at 11:14:15PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > sti seems confused about which mode list is used in its .get_modes() > hook. It adds the modes to the probed_modes list (as is appropriate) > but then for some reason it tries to sort the old mode list. > > Just drop the sorting since it does nothing, and let the probe helper > do its thing. It will sort the final mode list after merging in the > modes from the probed_modes list and validating them. > > Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx> > Cc: Vincent Abriou <vincent.abriou@xxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/sti/sti_hda.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c > index d735daccd458..49cce833f2c8 100644 > --- a/drivers/gpu/drm/sti/sti_hda.c > +++ b/drivers/gpu/drm/sti/sti_hda.c > @@ -543,8 +543,6 @@ static int sti_hda_connector_get_modes(struct drm_connector *connector) > count++; > } > > - drm_mode_sort(&connector->modes); > - Yeah I've just written the kerneldoc for ->get_modes, this is bogus. Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > return count; > } > > -- > 2.4.10 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
