Re: [PATCH 2/2] drm/exynos: dp: fix wrong return type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Javier,

2015년 11월 26일 22:35에 Javier Martinez Canillas 이(가) 쓴 글:
> [adding Ajay Kumar who added the bridge support]
> 
> Hello Inki,
> 
> On 11/26/2015 09:47 AM, Inki Dae wrote:
>> This patch fixes wrong return type when dt binding of bridge device
>> failed.
>>
>> If a board has a bridge device then of_graph_get_remote_port_parent
>> function shouldn't be NULL. So this patch will return a proper error
>> type so that the deferred probe isn't triggered.
>>
>> Signed-off-by: Inki Dae <inki.dae@xxxxxxxxxxx>
>> ---
>>  drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
>> index 0b53045..c77fb83 100644
>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
>> @@ -1436,8 +1436,10 @@ static int exynos_dp_probe(struct platform_device *pdev)
>>  			of_node_put(bridge_node);
>>  			if (!dp->ptn_bridge)
>>  				return -EPROBE_DEFER;
>> -		} else
>> -			return -EPROBE_DEFER;
>> +		} else {
>> +			DRM_ERROR("no port node for bridge device.\n");
>> +			return -ENXIO;
>> +		}
>>  	}
>>  
> 
> As I mentioned in the other thread, I wonder if -ENXIO is the best errno
> code in this case. Shouldn't -EINVAL be more appropriate since is about
> an invalid DTB?

Seems better to use -EINVAL.

Thanks,
Inki Dae

> 
>>  	pm_runtime_enable(dev);
>>
> 
> Best regards,
> 
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux