Re: [PATCH] drm: Do not set connector->encoder in drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 17, 2015 at 04:58:25PM +0200, Jani Nikula wrote:
> On Mon, 16 Nov 2015, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> > An encoder is associated with a connector by the DRM core as a result of
> > setting up a configuration. Drivers using the atomic or legacy helpers
> > should never set up this link, even if it is a static one.
> 
> Not to block this patch in any way, but really this kind of stuff should
> end up in the struct drm_connector kernel-doc. Although it's already a
> monster.

In 4.4 we can split up the kerneldoc for structures into per-member
comments, which was added exactly to handle monsters like this. Also, with
the per-member comment layout you can do full paragraphs to explain tricky
bits like this separately and are no longer limited to the single
(continuated if needed) line we have right now.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux