On Sun, Nov 01, 2015 at 02:22:00PM +0100, Lukas Wunner wrote:
> I noticed that intel_fbdev->our_mode is unused. Introduced by
> 79e539453b34 ("DRM: i915: add mode setting support").
>
> Then I noticed that intel_fbdev->fbdev_list is unused as well.
> Introduced by 386516744ba4 ("drm/fb: fix fbdev object model +
> cleanup properly.") in i915, nouveau and radeon.
>
> Subsequently cargo culted to amdgpu, ast, cirrus, qxl, udl,
> virtio and mgag200.
>
> Already removed from the latter with cc59487a05b1 ("drm/mgag200:
> 'fbdev_list' in 'struct mga_fbdev' is not used").
>
> Remove it from the others.
Applied to drm-misc, thanks.
-Daniel
>
> Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 1 -
> drivers/gpu/drm/ast/ast_drv.h | 1 -
> drivers/gpu/drm/cirrus/cirrus_drv.h | 1 -
> drivers/gpu/drm/i915/intel_drv.h | 2 --
> drivers/gpu/drm/nouveau/nouveau_fbcon.h | 1 -
> drivers/gpu/drm/qxl/qxl_fb.c | 1 -
> drivers/gpu/drm/radeon/radeon_fb.c | 1 -
> drivers/gpu/drm/udl/udl_fb.c | 1 -
> drivers/gpu/drm/virtio/virtgpu_fb.c | 1 -
> 9 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> index 96290d9..ab781b4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> @@ -45,7 +45,6 @@
> struct amdgpu_fbdev {
> struct drm_fb_helper helper;
> struct amdgpu_framebuffer rfb;
> - struct list_head fbdev_list;
> struct amdgpu_device *adev;
> };
>
> diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h
> index 86205a2..69e2a62 100644
> --- a/drivers/gpu/drm/ast/ast_drv.h
> +++ b/drivers/gpu/drm/ast/ast_drv.h
> @@ -256,7 +256,6 @@ struct ast_framebuffer {
> struct ast_fbdev {
> struct drm_fb_helper helper;
> struct ast_framebuffer afb;
> - struct list_head fbdev_list;
> void *sysram;
> int size;
> struct ttm_bo_kmap_obj mapping;
> diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.h b/drivers/gpu/drm/cirrus/cirrus_drv.h
> index 7050615..d772f7a 100644
> --- a/drivers/gpu/drm/cirrus/cirrus_drv.h
> +++ b/drivers/gpu/drm/cirrus/cirrus_drv.h
> @@ -153,7 +153,6 @@ struct cirrus_device {
> struct cirrus_fbdev {
> struct drm_fb_helper helper;
> struct cirrus_framebuffer gfb;
> - struct list_head fbdev_list;
> void *sysram;
> int size;
> int x1, y1, x2, y2; /* dirty rect */
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 0598932..d792665 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -123,8 +123,6 @@ struct intel_framebuffer {
> struct intel_fbdev {
> struct drm_fb_helper helper;
> struct intel_framebuffer *fb;
> - struct list_head fbdev_list;
> - struct drm_display_mode *our_mode;
> int preferred_bpp;
> };
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.h b/drivers/gpu/drm/nouveau/nouveau_fbcon.h
> index 1e2e9e2..ca77ad0 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.h
> +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.h
> @@ -34,7 +34,6 @@
> struct nouveau_fbdev {
> struct drm_fb_helper helper;
> struct nouveau_framebuffer nouveau_fb;
> - struct list_head fbdev_list;
> struct drm_device *dev;
> unsigned int saved_flags;
> struct nvif_object surf2d;
> diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
> index c4a5526..a97d167 100644
> --- a/drivers/gpu/drm/qxl/qxl_fb.c
> +++ b/drivers/gpu/drm/qxl/qxl_fb.c
> @@ -40,7 +40,6 @@
> struct qxl_fbdev {
> struct drm_fb_helper helper;
> struct qxl_framebuffer qfb;
> - struct list_head fbdev_list;
> struct qxl_device *qdev;
>
> spinlock_t delayed_ops_lock;
> diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> index 26da2f4..adc44bb 100644
> --- a/drivers/gpu/drm/radeon/radeon_fb.c
> +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> @@ -44,7 +44,6 @@
> struct radeon_fbdev {
> struct drm_fb_helper helper;
> struct radeon_framebuffer rfb;
> - struct list_head fbdev_list;
> struct radeon_device *rdev;
> };
>
> diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
> index 62c7b1d..b9df46e 100644
> --- a/drivers/gpu/drm/udl/udl_fb.c
> +++ b/drivers/gpu/drm/udl/udl_fb.c
> @@ -33,7 +33,6 @@ module_param(fb_defio, int, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP);
> struct udl_fbdev {
> struct drm_fb_helper helper;
> struct udl_framebuffer ufb;
> - struct list_head fbdev_list;
> int fb_count;
> };
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c
> index 6a81e08..2242a80 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_fb.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c
> @@ -32,7 +32,6 @@
> struct virtio_gpu_fbdev {
> struct drm_fb_helper helper;
> struct virtio_gpu_framebuffer vgfb;
> - struct list_head fbdev_list;
> struct virtio_gpu_device *vgdev;
> struct delayed_work work;
> };
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
