Re: [PATCH v9 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

[Yakir Yang <ykk@xxxxxxxxxxxxxx>]

Hi Rob,

On 11/12/2015 07:10 AM, Rob Herring wrote:

On Fri, Oct 30, 2015 at 09:09:15AM +0800, Yakir Yang wrote:

Some edp screen do not have hpd signal, so we can't just return
failed when hpd plug in detect failed.

This is an hardware property, so we need add a devicetree property
"analogix,need-force-hpd" to indicate this sutiation.

Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
Tested-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Signed-off-by: Yakir Yang <ykk@xxxxxxxxxxxxxx>
---

I didn't find this one in v10. Did it get dropped?

You are in my 'to' list, but I haven't send the whole v10 out,
most of them don't need update :)

This series should be:
---- [v8 0/17 ...]
  |---- [v8 1/17 ...]
  |---- [v8 2/17 ...]
  |---- [v8 3/17 ...]
  |---- [...]
  |---- [v8 15/17 ...]
  |---- [v8 16/17 ...]
  |---- [v8 17/17 ...]
  |
  |---- [v9 10/17 ...]
  |---- [v9 15/17 ...]
     |---- We are here
  |---- [v9 09/17 ...]
  |---- [v10 09/17 ...]
     |---- Received an acked from you

Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- Add "analogix,need-force-hpd" to indicate whether driver need foce
  hpd when hpd detect failed.

Changes in v2: None

 .../bindings/display/bridge/analogix_dp.txt        |  4 ++-
 .../bindings/display/exynos/exynos_dp.txt          |  1 +
 .../display/rockchip/analogix_dp-rockchip.txt      |  1 +
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 36 +++++++++++++++++++---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |  2 ++
 drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c  |  9 ++++++
 6 files changed, 47 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
index 7659a7a..74f0e80 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
+++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
@@ -22,6 +22,9 @@ Required properties for dp-controller:
 		from general PHY binding: Should be "dp".
 
 Optional properties for dp-controller:
+	-analogix,need-force-hpd:
+		Indicate driver need force hpd when hpd detect failed, this
+		is used for some eDP screen which don't have hpd signal.

This should be a generic property.

This property would only need in some no-hpd case, it would be dropped if
panel keep the hotplug signal, that's why I thought it should be optional.

I thought if we put this a property to generic property, then we must need
to define it in normal device node, not sure whether it is right :)

Thanks,
- Yakir

Rob

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel