On Fri, 06 Nov 2015, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Fri, 6 Nov 2015 13:38:22 +0100 > > The pwm_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. The compiler doesn't need it, but IMO it's useful documentation for humans. BR, Jani. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_panel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > index a24df35..3d8d913 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -1729,8 +1729,7 @@ void intel_panel_destroy_backlight(struct drm_connector *connector) > struct intel_panel *panel = &intel_connector->panel; > > /* dispose of the pwm */ > - if (panel->backlight.pwm) > - pwm_put(panel->backlight.pwm); > + pwm_put(panel->backlight.pwm); > > panel->backlight.present = false; > } -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
