Regards
Shashank
On 10/13/2015 7:29 PM, Emil Velikov wrote:
On 13 October 2015 at 14:40, Sharma, Shashank <shashank.sharma@xxxxxxxxx> wrote:
I am not sure if I915 follows a general rule of using for(...) over while(),
coz I see many instances of using a while in i915_gem, i915_drv, i915_irq
etc, so it should be good. I would see if someone else can suggest another
good reason.
I'm not saying "you should never use while loops", but more of "people
use for loops when accessing arrays of information". I cannot see any
cases of the latter in i915. Perhaps I'm looking at some old code ?
The point I'm trying to make here is that people are unlikely to make
comments about such trivial nitpicks (bikeshedding), but new
contributions should stick with the existing approach, rather than
going for "I like XXX" :)
Take any and all of my with a grain of salt, just in case.
Its a very well written and logical comment, but I like this last line
the most :) :)
Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
