Hi Emil, On 2015년 09월 30일 21:19, Emil Velikov wrote: > Hi Inki, > > On 30 September 2015 at 12:21, Inki Dae <inki.dae@xxxxxxxxxxx> wrote: >> This patch removes unnecessary pm suspend/resume functions. >> >> All kms sub drivers will be controlled by top of Exynos drm driver >> and connector dpms so these sub drivers shouldn't have their own >> pm interfaces. >> > Not sure if you've noticed but this patch seems to do the opposite of > what Gustavo was aiming with an earlier series [1]. I removed just the interfaces related to sleep pm not runtime pm. From long ago, Linux DRM drivers - especially ARM DRM drivers - have been stepping forward to a integrated DRM driver so it'd be reasonable for sleep pm operations of all KMS drivers are controlled by top of DRM driver. It means that Exynos drm driver has already sleep pm interfaces. However, I think a power domain of each kms device couldn't be controlled by the top in case of ARM SoC because kms devices can use a different power domain each other according to Vendor SoC so runtime pm should be controlled by each kms driver, which will be triggered by DRM top. And Gustavo's patch set you mentioned - now being reviewed - will add only runtime pm interfaces to each kms driver. Thanks, Inki Dae > > Cheers, > Emil > > [1] http://lists.freedesktop.org/archives/dri-devel/2015-September/089800.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
