On Tue, Sep 29, 2015 at 03:39:03PM +0100, Robert Bragg wrote: > Updating Mesa and GPU Top to experiment with this was straightforward > given the similarity to the perf interface. The main difference is that > it only supports forwarding metrics via read()s instead of an mmaped > circular buffer. As mentioned above, I think that suits this well, and > requires no additional copying of data. I think the userspace code has > ended up being a little simpler too. Did you try updating the existing perf based overlay? > Overall the driver currently isn't much more code than with perf (~200 > lines). > > Personally my gut feeling a.t.m, is that we should aim to move forward > independent from perf. > > I'd really appreciate some feedback from others on this though. > > Daniel and Chris; although I think it made sense at the outset to try > and use perf, in light of the above would you be open to a non-perf > based driver for the OA unit? No. I strongly dislike that they will be multiple incompatibile perf interfaces and strongly like the coupling with other profiling that comes with perf - i.e. we very much want to simultaneously sample CPU and GPU workloads along with other devices, that information is much more useful to me for the purposes of scheduling work and maximising concurrency than optimising shaders. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel