Am Freitag, den 25.09.2015, 15:09 +0200 schrieb Philipp Zabel: > Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding: > > I think you gain much less by splitting up than you realize. Compare > > this from before the series: > > > > $ du -ch drivers/gpu/drm/imx/*.ko > > 8.0K drivers/gpu/drm/imx/dw_hdmi-imx.ko > > Oh right, I didn't realize that this is just the shim. The bulk of the > HDMI driver is in bridge/dw_hdmi.ko. > > > 16K drivers/gpu/drm/imx/imxdrm.ko > > 16K drivers/gpu/drm/imx/imx-ipuv3-crtc.ko > > 12K drivers/gpu/drm/imx/imx-ldb.ko > > 12K drivers/gpu/drm/imx/imx-tve.ko > > 8.0K drivers/gpu/drm/imx/parallel-display.ko > > 72K total > [...] > > with this after the series: > > > > $ du -ch drivers/gpu/drm/imx/*.ko > > 44K drivers/gpu/drm/imx/imx-drm.ko > > 44K total > [...] > > There are other things to consider as well, such as the additional > > memory overhead caused by merely having multiple modules, or all of the > > exported functions that unnecessarily clutter up the symbol table, and > > which end up slowing down every symbol lookup. > > Thanks, can't argue with those numbers. > I'll queue patches 3 and 4 for imx-drm. Wait, I won't because they depend on the helper function in patch 1. Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> then. Can I get a stable tag so I can solve potential merge conflicts in imx-drm-core.c? regards Philipp _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
