Good catch! Reviewed-by: Sinclair Yeh <syeh@xxxxxxxxxx> On Sat, Sep 19, 2015 at 12:31:10AM +0200, Christian Engelmayer wrote: > Function vmw_cotable_unbind() uses the uninitialized variable ret as > return value. Make the result deterministic and directly return as > the variable is unused anyway. Detected by Coverity CID 1324256. > > Signed-off-by: Christian Engelmayer <cengelma@xxxxxx> > --- > Compile tested only. Applies against linux-next. > --- > drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > index ce659a125f2b..092ea81eeff7 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > @@ -311,7 +311,6 @@ static int vmw_cotable_unbind(struct vmw_resource *res, > struct vmw_private *dev_priv = res->dev_priv; > struct ttm_buffer_object *bo = val_buf->bo; > struct vmw_fence_obj *fence; > - int ret; > > if (list_empty(&res->mob_head)) > return 0; > @@ -328,7 +327,7 @@ static int vmw_cotable_unbind(struct vmw_resource *res, > if (likely(fence != NULL)) > vmw_fence_obj_unreference(&fence); > > - return ret; > + return 0; > } > > /** > -- > 1.9.1 > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
