Re: [PATCH RFCv2 3/4] staging: etnaviv: add drm driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lucas Stach <l.stach@xxxxxxxxxxxxxx> writes:

> From: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>

> +static bool etnaviv_validate_load_state(struct etnaviv_gpu *gpu, u32 *buf,
> +	unsigned int state, unsigned int num)
> +{
> +	return true;
> +	if (0x1200 - state < num * 4)
> +		return false;
> +	if (0x1228 - state < num * 4)
> +		return false;
> +	if (0x1238 - state < num * 4)
> +		return false;
> +	if (0x1284 - state < num * 4)
> +		return false;
> +	if (0x128c - state < num * 4)
> +		return false;
> +	if (0x1304 - state < num * 4)
> +		return false;
> +	if (0x1310 - state < num * 4)
> +		return false;
> +	if (0x1318 - state < num * 4)
> +		return false;
> +	if (0x1280c - state < num * 4 + 0x0c)
> +		return false;
> +	if (0x128ac - state < num * 4 + 0x0c)
> +		return false;
> +	if (0x128cc - state < num * 4 + 0x0c)
> +		return false;
> +	if (0x1297c - state < num * 4 + 0x0c)
> +		return false;
> +	return true;
> +}

I was browsing the code, and noticed that it looks like you've got a
debugging early return in your validation function here.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux