2015-09-16 10:04 GMT+02:00 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>: > On Fri, Sep 11, 2015 at 04:10:13PM +0200, Lucas Stach wrote: >> From: Christian Gmeiner <christian.gmeiner@xxxxxxxxx> >> >> This is a squashed commit of the complete etnaviv DRM driver in order >> to make it easy for people to review the code by seeing the driver as a >> whole and is not intended for merging in this form. >> >> If you are interested in the history of individual commits: >> git://git.pengutronix.de/git/lst/linux.git etnaviv-for-upstream >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx> >> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> >> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > Lucas, > > I know that the previous round, people said that they didn't like the > individual patches posted, but squashing everything together into one > patch is also not good. > > It would make more sense (at least for me) if you squashed the work > that has already been done into one patch, and then post your updates > as individual patches. That way, Christian and myself can see what > the changes are against some known without having to dig through your > git tree, and those who complained about all the patches last time > have fewer patches to look at. > > Expecting those in the project to page through thousands of lines that > they already know about, hoping to spot the changes you've made is > really very unreasonable and error prone. I will _NOT_ be wasting my > time reviewing this mega-patch exactly because of that. > Yep it quite hard to review it that way - I only had a look at the user space <-> kernel space api/abi. greets -- Christian Gmeiner, MSc https://soundcloud.com/christian-gmeiner _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
