Hello! Inki Dae wrote: > On 2015년 08월 24일 23:13, Tobias Jakobi wrote: >> The amount of commands (regular and GEM) doesn't depend >> on the input here. >> >> Signed-off-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx> >> --- >> exynos/exynos_fimg2d.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c >> index 1ae8adf..9b7bcce 100644 >> --- a/exynos/exynos_fimg2d.c >> +++ b/exynos/exynos_fimg2d.c >> @@ -319,6 +319,9 @@ g2d_solid_fill(struct g2d_context *ctx, struct g2d_image *img, >> union g2d_bitblt_cmd_val bitblt; >> union g2d_point_val pt; >> >> + if (g2d_check_space(ctx, 7, 1)) >> + return -ENOSPC; > > You can make 3 and 4 patches to one. These should be same patch. Hmm, so which 3 (respectively 4) patches should be squashed? I tried to separate stuff to make review easier. If squashing here is the only issue, do I need to resend the series or can e.g. Emil just do the squash when merging? With best wishes, Tobias > >> + >> g2d_add_cmd(ctx, DST_SELECT_REG, G2D_SELECT_MODE_NORMAL); >> g2d_add_cmd(ctx, DST_COLOR_MODE_REG, img->color_mode); >> g2d_add_base_addr(ctx, img, g2d_dst); >> > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
